milter messages marked as ALL_TRUSTED

[Matus UHLAR - fantomas]

>>>On Wed, Apr 22, 2020 at 01:40:32PM +0300, Henrik K wrote:
>>>> Actually I found the problem, looking at my locally patched amavisd..
>>>>
>>>> The patch is missing one call.
>>>>
>>>> Look for string
>>>>
>>>> # load policy banks from the 'client_ipaddr_policy' lookup
>>>>
>>>> ... there's two of those
>>>>
>>>> But this first one was missing the $msginfo->originating call...  this is
>>>> inside the check_ampdp_policy function which I think is used with amavisd-milter
>>>>
>>>>     # load policy banks from the 'client_ipaddr_policy' lookup
>>>>     Amavis::load_policy_bank($_,$msginfo) for @bank_names_cl;
>>>>     $msginfo->originating(c('originating'));
>>>>     # additional banks from the request
>>>>     Amavis::load_policy_bank(untaint($_),$msginfo) for @$bank_names_ref;
>>>>
>>>> I'll investigate a bit more how to do this the most clean way, but adding
>>>> that $msginfo->originating(c('originating')); will make it work..
>
>>On Wed, Apr 22, 2020 at 02:21:25PM +0300, Henrik K wrote:
>>>Bug filed:
>>>
>>>https://gitlab.com/amavis/amavis/-/issues/61

On 22.04.20 13:47, Matus UHLAR - fantomas wrote:
>great, I'll try the patch

... and it seems to work!

some mail don't hit ALL_TRUSTED now, apparently because fe80:: addresses.
But this is a configuration error not an amavis bug!


-- 
Matus UHLAR - fantomas, uhlar at fantomas.sk ; http://www.fantomas.sk/
Warning: I wish NOT to receive e-mail advertising to this address.
Varovanie: na tuto adresu chcem NEDOSTAVAT akukolvek reklamnu postu.
"Where do you want to go to die?" [Microsoft]