amavisd-new 2.8.0 -- amavis_required_score.patch

[Renato Botelho]

On Tue, Jul 17, 2012 at 7:54 AM, Mark Martinec
<Mark.Martinec+amavis at ijs.si> wrote:
> Florin,
>
>
>> I'm interested to know if by default this patch has been integrated
>> into new fork of amavisd-new.
>>
>> The one which allow to use sql_prefs for spamassassin instead of
>> defined score in amavisd.conf.
>
>
> Which patch are you referring to?
>
> Using the SpamAssassin's PMS->get_required_score from amavisd
> doesn't play well with amavisd's handling of per-recipient
> score thresholds. Amavisd traditionally calls SpamAssassin
> only once even for multi-recipient messages, then does
> per-recipient handling by itself. Using the required_score
> would require calling SA once for each recipient.
>
> The version 2.7.0 of amavisd went ahead in this direction
> and allowed calling SpamAssassin once for each recipient,
> and using SpamAssassin's user preferences SQL lookups.
> This comes at a cost, both in speed and in memory, as
> saving and restoring SpamAssassin state is rather expensive.
> Still, even with such a setup the required_score is
> currently ignored.
>
> So a short answer is: no, using required_score from
> SpamAssassin's SQL lookups is currently not practical.

Hello Mark,

In some scenarios, you need to respect user's preferences
for required_score settings, and it's mandatory. Don't you
agree use it, even if it consumes more resources, is up to
the user is administrating the setup?

I talk for myself, when i wrote the patch for 2.7.0 [1], I did it
because on my setup, it's mandatory to respect user's preferences
for required_score, and we provided necessary resources to have
this working as well.

I'm still running amavis with this patch and it's working fine,
but it's really complicated to keep updating patches for each
new version. Please, consider include this as optional, off
by default, with a big warning message saying if someone
choose to use it, there will be a cost, and leave users take
their decisions.

Best Regards

[1] http://lists.amavis.org/pipermail/amavis-users/2011-August/000686.html
-- 
Renato Botelho