amavis ldap trouble in process_request do_search

[Mark Martinec]

Quanah,

> Here is my patch:
> 
> @@ -18400,9 +18414,12 @@
>                              localaddr => $self->{localaddr},
>                              port    => $self->{port},
>                              scheme  => $self->{scheme},
> -                            inet6   => $self->{inet6},
>                              version => $self->{version},
>                              timeout => $self->{timeout},
> +                            keepalive => 1,
> +                            keepalive_idle => 240,
> +                            keepalive_interval => 30,
> +                            keepalive_probe => 10,
>                              );
> 
> The "keepalive" option is what is new and native to Net::LDAP.  There is no 
> effect if someone is running a version that doesn't have it (no error).
> 
> I would note that "inet6" is not valid, and may cause problems, with newer 
> Net::LDAP installations.
> 
> The additional keepalive parameters only do something if someone has 
> applied my patch for Net::LDAP during their module build.  That is here:
> 
> <https://rt.cpan.org/Ticket/Display.html?id=83039>
> 
> There is some disagreement from the Net::LDAP authors about including this 
> patch at the moment. ;)

Thanks, applied.

> > I would note that "inet6" is not valid, and may cause problems, with
> > newer Net::LDAP installations.
> 
> Specifically, IIRC, it changed meaning.  In older releases, it meant that
> Net::LDAP could support inet6.  In later releases, it means IPv6 *only*.
> This resulted in errors like [...] on IPv4 only systems.

That's a terrible incompatible change. In Net::LDAP 0.44 it clearly states
that the option does no harm if the host resolves to an IPv4-only address:

  inet6 => N
    Try to connect to the server using IPv6 if "HOST" resolves to
    an IPv6 target address.  If it resolves to an IPv4 address, the
    connection is tried using IPv4, the same way as if this option
    was not given.


Ok, removing, thanks.

  Mark